Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASWebAuthenticationSession support in OIDExternalUserAgentMac. #675

Merged
merged 6 commits into from
Feb 14, 2022
Merged

Add ASWebAuthenticationSession support in OIDExternalUserAgentMac. #675

merged 6 commits into from
Feb 14, 2022

Conversation

Alex-4-Git
Copy link
Contributor

This is the first step of support ASWebAuthenticationSession in AppAuth for macOS.
The following commit will apply this to OIDAuthState+mac and modify mocOS example app accordingly.

@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 13, 2022 18:44
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch 2 times, most recently from 763fda5 to dc062e6 Compare January 14, 2022 00:39
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from dc062e6 to 8bf91ca Compare January 14, 2022 01:09
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from 8bf91ca to 7d02c8a Compare January 14, 2022 01:11
@petea petea self-requested a review January 14, 2022 01:46
petea
petea requested changes Feb 2, 2022
View reviewed changes
Source/AppAuth/macOS/OIDExternalUserAgentMac.h Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDExternalUserAgentMac.m Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDAuthState+Mac.h Show resolved Hide resolved
Source/AppAuth/macOS/OIDAuthState+Mac.h Outdated Show resolved Hide resolved
@Alex-4-Git Alex-4-Git requested a review from petea February 3, 2022 22:23
petea
petea requested changes Feb 7, 2022
View reviewed changes
Source/AppAuth/macOS/OIDAuthState+Mac.h Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDExternalUserAgentMac.h Outdated Show resolved Hide resolved
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch 2 times, most recently from d27a479 to 67dedc1 Compare February 8, 2022 00:20
petea
petea requested changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@petea petea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should an osx.weak_frameworks entry to the podspec for AuthenticationServices, as we've done for iOS.

Source/AppAuth/macOS/OIDAuthState+Mac.h Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDExternalUserAgentMac.h Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDExternalUserAgentMac.m Outdated Show resolved Hide resolved
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from 67dedc1 to aef7cd9 Compare February 8, 2022 21:58
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from aef7cd9 to dd0681d Compare February 8, 2022 22:52
@Alex-4-Git Alex-4-Git requested a review from petea February 9, 2022 04:55
petea
petea requested changes Feb 10, 2022
View reviewed changes
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Examples/Example-macOS/Source/AppAuthExampleViewController.m Outdated Show resolved Hide resolved
Source/AppAuth/macOS/OIDExternalUserAgentMac.m Outdated Show resolved Hide resolved
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from 604c91d to 414f282 Compare February 10, 2022 22:15
@Alex-4-Git Alex-4-Git force-pushed the pin-ASWebAuthenticationSessionSupport branch from 414f282 to 069fa7a Compare February 10, 2022 22:20
@petea petea merged commit 9ae7c24 into openid:master Feb 14, 2022
@petea petea added this to the 1.5.0 milestone Mar 17, 2022
eigentone11 added a commit to eigentone11/AppAuth-iOS that referenced this pull request Jun 15, 2022
@eigentone11
Merge branch 'master' of https://github.com/openid/AppAuth-iOS
156376f 
* 'master' of https://github.com/openid/AppAuth-iOS: (22 commits)
  Update issue templates
  Bump cocoapods-downloader from 1.5.1 to 1.6.3 (openid#700)
  Update issue templates (openid#699)
  Remove empty AppAuthEnterpriseUserAgent folder from Xcode project. (openid#697)
  Fix changelog typo.
  Prepare for 1.5.0 release (openid#692)
  Rollback the EnterpriseUserAgent target. (openid#693)
  Run tests against the Xcode project (openid#696)
  Run pod lib lint tests (openid#695)
  Have swift test generate code coverage.
  Reenable Codecov.
  Update tests badge.
  Set min iOS version to 9 for SPM (openid#690)
  Document the design principles behind AppAuth
  Add ASWebAuthenticationSession support in OIDExternalUserAgentMac. (openid#675)
  Use TARGET_OS_OSX for macOS rather than TARGET_OS_MAC (openid#681)
  Fix up type in designated initializer (openid#662)
  Remove unmatched diagnostic pop (openid#641)
  Fix branch name
  Update init unavailable doc on OIDServiceDiscovery (openid#640)
  ...

# Conflicts:
#	AppAuth.xcodeproj/project.pbxproj
#	AppAuth.xcodeproj/xcshareddata/xcschemes/AppAuthEnterpriseUserAgent.xcscheme
#	Package.swift
eigentone11 added a commit to eigentone11/AppAuth-iOS that referenced this pull request Jun 15, 2022
@eigentone11
Merge branch 'master' into backend-auth
6bdc94a 
* master: (25 commits)
  added missing import
  ignore deprecated
  take xcode's recommended updates
  Update issue templates
  Bump cocoapods-downloader from 1.5.1 to 1.6.3 (openid#700)
  Update issue templates (openid#699)
  Remove empty AppAuthEnterpriseUserAgent folder from Xcode project. (openid#697)
  Fix changelog typo.
  Prepare for 1.5.0 release (openid#692)
  Rollback the EnterpriseUserAgent target. (openid#693)
  Run tests against the Xcode project (openid#696)
  Run pod lib lint tests (openid#695)
  Have swift test generate code coverage.
  Reenable Codecov.
  Update tests badge.
  Set min iOS version to 9 for SPM (openid#690)
  Document the design principles behind AppAuth
  Add ASWebAuthenticationSession support in OIDExternalUserAgentMac. (openid#675)
  Use TARGET_OS_OSX for macOS rather than TARGET_OS_MAC (openid#681)
  Fix up type in designated initializer (openid#662)
  ...

# Conflicts:
#	Package.swift
@petea petea mentioned this pull request Aug 16, 2022
Merged
tonyphn pushed a commit to brighthr/AppAuth-iOS that referenced this pull request Feb 2, 2023
@Alex-4-Git @tonyphanbhr
Add ASWebAuthenticationSession support in OIDExternalUserAgentMac. (o…
63dfdfc 
…penid#675)

* Add ASWebAuthenticationSession support in OIDExternalUserAgentMac.

* Incorporate OIDExternalUserAgentMac change in OIDState+Mac and modify the macOS example app.

* Incorporate OIDExternalUserAgentMac change in OIDAuthorization+Mac and modify the macOS example app.

* Clean APIs and add more API documentations.

* Fix indentations in macOS example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petea petea petea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-4-Git @petea