Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the OpenIddict.Server unit tests from OpenIddict 2.x #894

Open
kevinchalet opened this issue Jan 14, 2020 · 2 comments
Open

Port the OpenIddict.Server unit tests from OpenIddict 2.x #894

kevinchalet opened this issue Jan 14, 2020 · 2 comments

Comments

@Darthruneis
Copy link
Contributor

@kevinchalet I'm considering taking a look at this one based on our discussion in #956 - can you clarify specifically what you mean when you say 'Port' the tests? My best guess is to fix them/update them after they have broken during changes for 3.0, is that correct?

@kevinchalet
Copy link
Member Author

Thanks @Darthruneis!

My best guess is to fix them/update them after they have broken during changes for 3.0, is that correct?

Yep, exactly. There are also new methods that were added to OpenIddictServerBuilder in 3.0 for which we'll need to add new unit tests after porting the tests class from 2.x (but it can be done in a separate PR).

Darthruneis added a commit to Darthruneis/openiddict-core that referenced this issue Jun 9, 2020
- Some tests would not work without the changes to how the Options were retrieved.
- The skipped tests are those that are currently failing on all frameworks.
Will be continuing to try to fix those.
- The commented out tests have compiler errors.
Will need to go through and see which, if any, are still valid.

Related Work Items: openiddict#894
@kevinchalet kevinchalet modified the milestones: 3.0.0-beta2, 3.0.0-beta3 Jun 30, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-beta3, 3.0.0-beta4 Jul 12, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-beta4, 3.0.0-beta5 Aug 25, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-beta5, 3.0.0-beta6 Oct 3, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-beta6, 3.0.0-rc1 Oct 18, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-rc1, 3.0.0-rc2 Nov 16, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0-rc2, 3.0.0 Dec 7, 2020
@kevinchalet kevinchalet modified the milestones: 3.0.0, 3.1.0-preview1 Dec 23, 2020
@kevinchalet kevinchalet removed this from the 4.0.0-preview4 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants