-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/approval request Fixes location of TestNoEagerReclaimOfHumongousRegions.java, affects test only, GHA testing OK |
/integrate |
Going to push as commit 7d36fed.
Your commit was automatically rebased without conflicts. |
TestNoEagerReclaimOfHumongousRegions.java
is placed (as the only test) ingc_implementation/g1
directory instead ofgc/g1
, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1.This seems like mistake in JDK-8139424 backport (orig, 8). Hotspot code uses dir named
gc_implementation
instead ofgc
on 8, but this is not the case for tests.This change moves
TestNoEagerReclaimOfHumongousRegions.java
hotspot test fromgc_implementation/g1
->gc/g1
.Testing:
tier1: OK (After this change, test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/551/head:pull/551
$ git checkout pull/551
Update a local copy of the PR:
$ git checkout pull/551
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/551/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 551
View PR using the GUI difftool:
$ git pr show -t 551
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/551.diff
Webrev
Link to Webrev Comment