Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209023: fix 2 compiler tests to avoid JDK-8208690 #590

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 2, 2024

Arm test runs of Test6891750 on adoptium infra fail with:

JavaTest Message: Problem cleaning up the following threads:
Thread-10
  at Test6891750.test(Test6891750.java:69)
  at Test6891750.run(Test6891750.java:88)

This simple backport (JDK-8209023) should fix that. Backport is not entirely clean because test was moved / put into java package in newer jdk (affecting @run line).

Testing:
GHA: OK (test passes, failures unrelated)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8209023 needs maintainer approval

Issue

  • JDK-8209023: fix 2 compiler tests to avoid JDK-8208690 (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/590/head:pull/590
$ git checkout pull/590

Update a local copy of the PR:
$ git checkout pull/590
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 590

View PR using the GUI difftool:
$ git pr show -t 590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/590.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8209023: fix 2 compiler tests to avoid JDK-8208690

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file
  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b3cf0cf9fcaa25f11f8b5fb8658ecb383d19fc17 8209023: fix 2 compiler tests to avoid JDK-8208690 Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 2, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2024

/approval request Fixes Test6891750.java test (only modifies test), GHA OK

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@zzambers
8209023: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 2, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Oct 3, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@jerboaa
8209023: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Oct 3, 2024

thanks
/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

Going to push as commit 6acc668.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file
  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2024
@openjdk openjdk bot closed this Oct 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@zzambers Pushed as commit 6acc668.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants