-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8209023: fix 2 compiler tests to avoid JDK-8208690 #590
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fixes Test6891750.java test (only modifies test), GHA OK |
/approve yes |
@jerboaa |
thanks |
Going to push as commit 6acc668.
Your commit was automatically rebased without conflicts. |
Arm test runs of
Test6891750
on adoptium infra fail with:This simple backport (JDK-8209023) should fix that. Backport is not entirely clean because test was moved / put into java package in newer jdk (affecting
@run
line).Testing:
GHA: OK (test passes, failures unrelated)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/590/head:pull/590
$ git checkout pull/590
Update a local copy of the PR:
$ git checkout pull/590
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/590/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 590
View PR using the GUI difftool:
$ git pr show -t 590
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/590.diff
Webrev
Link to Webrev Comment