Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: gradle-check action ran for different PR #2782

Closed
andrross opened this issue Oct 21, 2022 · 4 comments
Closed

[Bug]: gradle-check action ran for different PR #2782

andrross opened this issue Oct 21, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@andrross
Copy link
Member

Describe the bug

I submitted a revision to PR 4869 which appeared to trigger a gradle check action 5204. This reported a failure in my PR, but that gradle check action was actually for a different PR and ran against a different commit, leading to quite a lot of confusion. Seems like maybe a race condition?

More details here: opensearch-project/OpenSearch#4869 (comment)

To reproduce

Probably requires two PR submitting changes nearly simultaneously? Not sure how to deterministically reproduce.

Expected behavior

The gradle check action should run against my commit in my PR, not a different commit.

Screenshots

No response

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@andrross andrross added bug Something isn't working untriaged Issues that have not yet been triaged labels Oct 21, 2022
@peterzhuamazon
Copy link
Member

It is possible that it is a race condition tho I have not seen such cases happen until this point.
Will need to keep this open for a while as this might be a very rare case.

Thanks.

@andrross
Copy link
Member Author

I just observed a similar problem, but in this case it wasn't a PR workflow and instead was the gradle check that runs on merge. See this commit. The little red x links to this GitHub Action Workflow, which links to this gradle check jenkins run, which shows that it ran for an entirely different commit on a user fork

@jordarlu
Copy link
Contributor

jordarlu commented Apr 4, 2023

Could this be the casue ? actions/checkout#27
Also, both the wrong commit (sandeshkr419/OpenSearch@d3df6ee) and correct commit (opensearch-project/OpenSearch@1cdff3b) happened very closer to each other, could it be the GHA was first triggered by either one but them another one got pushed in before the GHA has completed?
Maybe we can open an issue with Github?

thanks,

@jordarlu
Copy link
Contributor

Hi, I am cloing this issue as it has been a while with no further updating from all stack holders in case... pls feel free to re-open or create a new one if you face the same issue ... thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants