Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend filtering for legacy internal user and service accounts #2786

Conversation

samuelcostae
Copy link
Contributor

@samuelcostae samuelcostae commented May 23, 2023

Description

Update UserAPIAction to Filter internal accounts and Service accounts.

Dashboards Plugin changes via PR opensearch-project/security-dashboards-plugin#1502

Issues Resolved

Testing

Unit Tests created

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@samuelcostae
Copy link
Contributor Author

@DarshitChanpura I had to a good bit of refactoring as I noticed that before, the beahviour in the PR was returning only the list of names of the accounts of the specified type, but the existing implementations on internalUsersAPI return the full account details.

@stephen-crawford stephen-crawford changed the title 2704 filter internal and service accounts Add backend filtering for legacy internal user and service accounts Jun 19, 2023
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I left a comment about tests, but I believe this should ready for final review.

@stephen-crawford
Copy link
Contributor

@samuelcostae could you rebase against main and resolve any conflicts.

@DarshitChanpura
Copy link
Member

@samuelcostae Please let us know if you would require any help to move this along.

@peternied
Copy link
Member

@samuelcostae Thanks for the updates - sorry its taken a little bit to circle back around to this pull requests.

@stephen-crawford
Copy link
Contributor

This is associated with #2704

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close. Final two comments.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last blocker in my mind is the structure of the UserService code, please iterate on @DarshitChanpura suggestion to slim down that code.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some feedback about the new unit tests - really close.

@peternied
Copy link
Member

@scrawfor99 Could you take another look?

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Sam :)

@stephen-crawford stephen-crawford merged commit 7f6944c into opensearch-project:main Sep 22, 2023
56 of 57 checks passed
RyanL1997 added a commit to RyanL1997/security that referenced this pull request Nov 2, 2023
Signed-off-by: Ryan Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extensions] Filter internal users for Service Accounts and add associated API
5 participants