Code coverage of OBO Authentication #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanL1997
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3428 +/- ##
============================================
+ Coverage 64.71% 64.99% +0.28%
- Complexity 3616 3638 +22
============================================
Files 281 281
Lines 20570 20581 +11
Branches 3400 3398 -2
============================================
+ Hits 13312 13377 +65
+ Misses 5557 5517 -40
+ Partials 1701 1687 -14
|
RyanL1997
force-pushed
the
obo-tests-cov
branch
2 times, most recently
from
641ae3e to
b166fee
Compare
|
@RyanL1997 it looks like spotless found some issues in this PR, can you fix those and push? It should also clean up the failing tests as I don't think they were related to your change. |
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
force-pushed
the
obo-tests-cov
branch
from
b166fee to
edfa292
Compare
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
force-pushed
the
obo-tests-cov
branch
from
ebaf13d to
e368dab
Compare
Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Thank you @RyanL1997. Could you add some final % number for code coverage?
src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
stephen-crawford
previously approved these changes
Oct 11, 2023
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
|
@RyanL1997 Is this ready for final review? |
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
approved these changes
Oct 12, 2023
stephen-crawford
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code coverage of OBO Authentication
Enhancement
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.