Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed time.Duration lint failure #34

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

eranco74
Copy link
Contributor

"/src/inventory_client/retry_roundtripper.go:23:11: cannot use rrt.delay (variable of type time.Duration) as time.Duration value in struct literal"

golangci/golangci-lint#995

@eranco74
Copy link
Contributor Author

I'll run a few /retest to make sure

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@eranco74
Copy link
Contributor Author

/retest

"/src/inventory_client/retry_roundtripper.go:23:11: cannot use rrt.delay (variable of type time.Duration) as time.Duration value in struct literal"
@eranco74
Copy link
Contributor Author

/retest

1 similar comment
@eranco74
Copy link
Contributor Author

/retest

@eranco74
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

@eranco74: No presubmit jobs available for openshift/assisted-installer@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eranco74
Copy link
Contributor Author

/test

@openshift-ci-robot
Copy link

@eranco74: No presubmit jobs available for openshift/assisted-installer@master

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya
Copy link
Contributor

tsorya commented Sep 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 83d688d into master Sep 14, 2020
@YuviGold YuviGold deleted the eran/lint branch October 5, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants