Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-39388: Filter out empty params before Shipwright build creation #14514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-39388: Filter out empty params before Shipwright build creation #14514

wants to merge 1 commit into from
+6 −1

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/OCPBUGS-39388

Descriptions:

  • Filter out empty params before Shipwright build creation as BuildRun fails if empty param values are passed.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 19, 2024
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-39388, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-39388

Descriptions:

  • Filter out empty params before Shipwright build creation as BuildRun fails if empty param values are passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj
Copy link
Member Author

/cc @lokanandaprabhu

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@vikram-raj
Copy link
Member Author

/retest

lokanandaprabhu
lokanandaprabhu reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikram-raj , I am trying to test the PR but getting Unknown in Last run status. Can you please mention if I am missing anything.

image

lokanandaprabhu
lokanandaprabhu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@vikram-raj
Copy link
Member Author

/retest

vikram-raj
vikram-raj commented Nov 22, 2024
View reviewed changes
Copy link
Member Author

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@vikram-raj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3fdea06 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@lokanandaprabhu lokanandaprabhu

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikram-raj @openshift-ci-robot @lokanandaprabhu