Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large chunks of text (1000+) cannot not be copied in CodeMirror #225

Closed
DeepAqua opened this issue Nov 4, 2017 · 12 comments
Closed

Large chunks of text (1000+) cannot not be copied in CodeMirror #225

DeepAqua opened this issue Nov 4, 2017 · 12 comments
Labels

Comments

@DeepAqua
Copy link

DeepAqua commented Nov 4, 2017

Stylus 1.1.4.2 in Firefox ESR (52.3.0) on Fedora


When trying to copy a selection of more than 1000 characters from CodeMirror, the selection instead contains only a single hyphen. This happens in any CodeMirror box, such as the editor, import, and export text boxes.

@tophf tophf added the external label Nov 5, 2017
@tophf
Copy link
Member

tophf commented Nov 5, 2017

Copying is handled by CodeMirror. See if their demo works for you https://codemirror.net and if not, report the bug in their repo.

@DeepAqua
Copy link
Author

DeepAqua commented Nov 5, 2017

The full screen demo has more than 1000 characters and copies correctly. This appears to be a problem with Stylus, or at least the version of CodeMirror it uses.

@tophf
Copy link
Member

tophf commented Nov 5, 2017

Yep, it was fixed in 5.28.0, but we use 5.27.4.
We'll update CM.

@tophf tophf closed this as completed in 397bfc7 Nov 5, 2017
tophf added a commit that referenced this issue Nov 5, 2017
@tophf
Copy link
Member

tophf commented Nov 5, 2017

@schomery, what about a maintenance release 1.1.4.3 on AMO to include several FF-related workarounds/fixes? If you agree, pull the locales and update manifest.json, please.

@narcolepticinsomniac
Copy link
Member

narcolepticinsomniac commented Nov 8, 2017

@schomery has gone dark again. Starring in those Dos Equis commercials really keeps him busy. He had said he wanted to transfer the AMO account as well, but he's still the only one with access to it currently.

FF 57 must've hit beta recently and the amount of illiterate, "tech-savvy" FF users is mind boggling. Many don't seem capable of reading or comprehending the disclaimer regarding UI styling, and appear to be completely oblivious when it comes to Mozilla's move to WebExtensions-only and the limitations which go along with it. I'm not claiming to always read descriptions either, but when something doesn't work as expected, I go back and read everything before unleashing my autism on the world.

AFAICT, 57 is scheduled to hit stable in about a week. Not only do we need to release 1.1.4.3 because of all the FF-related workarounds/fixes, but we need to update the description so that the disclaimer is more prominent. At the very least, it should be all caps in the first couple sentences, especially since AMO recently began obscuring all text past the first 8 sentences. If they allow markdown, it should also be bold and red or something. Hell, maybe we should even put it in the title.

I emailed schomery. Hopefully something gets his attention sometime soon.

Edit: Looking at US.o just now, the recent surge in user feedback is likely due to the fact that SimilarWeb released a new FF version, which is supposed to be a DB importer for the legacy Stylish, in preparation for the actual full update to come soon after. The import does not appear to be going smoothly for everybody, so I guess more users are exploring their options. Another reason to update ASAP.

@schomery
Copy link
Contributor

sorry guys. I had no access to my email. @tophf should I pack from the current master?

@schomery
Copy link
Contributor

@narcolepticinsomniac and @tophf the AMO account is moved to the Gmail account so you guys also have access to it. I'll move the Opera version too if possible.

@tophf
Copy link
Member

tophf commented Nov 14, 2017

Yeah, just pull dem da locales.

@schomery
Copy link
Contributor

done.

@tophf
Copy link
Member

tophf commented Nov 14, 2017

I've updated release info.

@tophf
Copy link
Member

tophf commented Nov 14, 2017

@schomery, no one spotted that Firefox options don't open now - I've fixed it, please reupload as 1.1.5 - usercss mode warrants the version bump.

@schomery
Copy link
Contributor

please reupload

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants