Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIRI Light #6284

Open
wants to merge 12 commits into
base: dev-2.x
Choose a base branch
from
Open

Implement SIRI Light #6284

wants to merge 12 commits into from

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Nov 27, 2024 •
edited
Loading

Summary

Implements the SIRI Light flavour (as opposed to the request/response one that Entur and Skanetrafiken uses). This means that the entire SIRI feed is download in a single GET request.

Issue

Closes #6263

Documentation

The new updater is fully documented and I took the liberty to make all references to SIRI consistent in the docs.

Unit tests

Some added, but it's mostly wiring. I'm happy to add more if requested but generally we don't test the HTTP layer a lot.

cc @rcavaliere @Jouca

@leonardehrenfried leonardehrenfried added New Feature Real-Time Update The issue/PR is related to RealTime updates labels Nov 27, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 27, 2024 12:51
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.38462% with 71 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (0dc9e57) to head (6703d62).
Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...updater/light/SiriETLightHttpTripUpdateSource.java 0.00% 27 Missing ⚠️
...planner/updater/configure/UpdaterConfigurator.java 0.00% 16 Missing and 2 partials ⚠️
...ripplanner/updater/siri/updater/SiriETUpdater.java 0.00% 9 Missing ⚠️
...ripplanner/updater/siri/updater/SiriSXUpdater.java 0.00% 7 Missing ⚠️
...ri/updater/light/SiriETLightUpdaterParameters.java 25.00% 3 Missing ⚠️
...ri/updater/light/SiriSXLightUpdaterParameters.java 25.00% 3 Missing ⚠️
...outerconfig/updaters/SiriETLightUpdaterConfig.java 95.45% 1 Missing ⚠️
...outerconfig/updaters/SiriSXLightUpdaterConfig.java 95.45% 1 Missing ⚠️
...dater/siri/updater/SiriETHttpTripUpdateSource.java 0.00% 1 Missing ⚠️
...pdater/siri/updater/light/SiriLightHttpLoader.java 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             dev-2.x    #6284      +/-   ##
=============================================
- Coverage      69.78%   69.75%   -0.04%     
- Complexity     17781    17791      +10     
=============================================
  Files           2017     2023       +6     
  Lines          76040    76154     +114     
  Branches        7781     7784       +3     
=============================================
+ Hits           53067    53122      +55     
- Misses         20269    20324      +55     
- Partials        2704     2708       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried changed the title Implement SIRI light Implement SIRI Light Nov 28, 2024
@leonardehrenfried
Copy link
Member Author

@habrahamsson-skanetrafiken Can I ask you to review this one? If not let me know and I will reassign.

@leonardehrenfried
Copy link
Member Author

It never occurred to me until yesterday's meeting that I also could have made the current updater/loader configurable. Let me know if you feel that's the better option, @t2gran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t2gran t2gran Awaiting requested review from t2gran

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken Awaiting requested review from habrahamsson-skanetrafiken

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
New Feature Real-Time Update The issue/PR is related to RealTime updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SIRI light
1 participant
@leonardehrenfried