Add carsAllowedStopMaxTransferDurationsForMode build config parameter #6215
Conversation
…th the 'carsAllowedStopMaxTransferDurationsForMode' build config parameter.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6215 +/- ##
=============================================
+ Coverage 69.91% 69.93% +0.02%
- Complexity 17736 17750 +14
=============================================
Files 2006 2007 +1
Lines 75526 75587 +61
Branches 7730 7739 +9
=============================================
+ Hits 52804 52862 +58
Misses 20036 20036
- Partials 2686 2689 +3 ☔ View full report in Codecov by Sentry. |
|
There are some conflicts |
habrahamsson-skanetrafiken
requested review from
optionsome and
leonardehrenfried
…into car-transferrequest-filtering
There was a problem hiding this comment.
I've had too many reviews today already so I didn't go properly through this. However, inspired by some concerns from @t2gran, I think to avoid issues we should do a couple of things:
- Introduce
carsAllowedStopMaxAccessEgressDurationsForMode. This is to prevent weird back-and-forth transfers to avoid access and egress duration limitations. - Prevent these transfers from being used by other street modes. I don't know if this is already done or not but I think at least previously all the transfers were in the same collection. This could again lead to weird back and forth travel by walking for example to escape some other restrictions.
| mBuilder.withEgressMode(StreetMode.WALK); | ||
| mBuilder.withDirectMode(StreetMode.CAR); | ||
| // This is used in transfer cache request calculations. | ||
| mBuilder.withAllStreetModes(StreetMode.CAR); |
There was a problem hiding this comment.
I know this builder method wasn't introduced in this pr but this name is really confusing. Idk what we call Access+Transfer+Egress+Direct. It's difficult to come up with a name that doesn't confuse you into thinking that all modes are enabled. Just making this singular would maybe make it less confusing.
| @@ -60,6 +68,23 @@ public DirectTransferGenerator( | |||
| this.issueStore = issueStore; | |||
| this.radiusByDuration = radiusByDuration; | |||
| this.transferRequests = transferRequests; | |||
| this.carsAllowedStopMaxTransferDurationsForMode = DurationForEnum.of(StreetMode.class).build(); | |||
There was a problem hiding this comment.
Maybe we should always include this with some default value that is the same as the normal transfer duration limit.
| .stream() | ||
| .map(StopLocation::getId) | ||
| .map(graph::getStopVertexForStopId) | ||
| .filter(TransitStopVertex.class::isInstance) // filter out null values if no TransitStopVertex is found for ID |
There was a problem hiding this comment.
Inline comments are not allowed.
|
I'm changing this to a draft for now. I'll return to this once the work on the separate transfer request collections for modes has been completed. |
Summary
This PR adds the
carsAllowedStopMaxTransferDurationsForModebuild config parameter for changing max transfer durations between stops that allow cars for the street modesBIKEandCAR. This is a follow-up PR related to #5966.Issue
This is a follow-up PR related to issue #5875.
Unit tests
I created new unit tests for testing the changes to the
DirectTransferGeneratorandStreetNearbyStopFinder.Documentation
Changes to
BuildConfiguration.mdBumping the serialization version id
This change affects how transfers are calculated and adds a new field to the
build-config.jsonfile.