Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor models to split torch_model, lightning_model and anomaly_map. #211

Closed
samet-akcay opened this issue Apr 8, 2022 · 0 comments · Fixed by #225
Closed

refactor models to split torch_model, lightning_model and anomaly_map. #211

samet-akcay opened this issue Apr 8, 2022 · 0 comments · Fixed by #225
Assignees
@djdameln
Labels
Model Refactor Refactoring is needed
Milestone
v0.3.0

Comments

@samet-akcay
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  • Currently all of the class implementations are stored in a single module called model.py. It would be better to split the implementations.

Describe the solution you'd like

  • Ideally an algorithm would have torch_model.py, lightning_model.py and anomaly_map.py to store the corresponding implementations.
@samet-akcay samet-akcay added Refactor Refactoring is needed Model labels Apr 8, 2022
@samet-akcay samet-akcay added this to the v0.2.7 milestone Apr 8, 2022
@djdameln djdameln mentioned this issue Apr 12, 2022
Merged
11 tasks
@djdameln djdameln moved this to 🚀 PR Created in Anomalib Apr 12, 2022
Repository owner moved this from 🚀 PR Created to Done in Anomalib Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djdameln djdameln

Labels
Model Refactor Refactoring is needed
Projects
Anomalib
Archived in project
Milestone
v0.3.0
2 participants
@samet-akcay @djdameln