Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of task_type parameter #34

Closed
djdameln opened this issue Dec 17, 2021 · 2 comments
Closed

Get rid of task_type parameter #34

djdameln opened this issue Dec 17, 2021 · 2 comments
Assignees
@djdameln
Labels
Config Enhancement New feature or request
Milestone
v0.3.0

Comments

@djdameln
Copy link
Contributor

The task_type parameter currently dictates which types of ground truth data is passed to the model. When the task_type parameter is set to segmentation, the ground truth pixel masks are passed in addition to the image-level labels. This might no longer be needed. Instead we can just pass whatever ground truth information is available, and let the PL module handle the evaluation based on what type of ground truth data it receives with the batches.
@samet-akcay samet-akcay added the Enhancement New feature or request label Jan 7, 2022
@daMichaelB
Copy link

i am not sure if i get something wrong, but as far as i see the task info is also not forwarded to the MVTecDataModule. I added it and then it works for classification also.

@djdameln djdameln mentioned this issue Mar 31, 2022
Closed
11 tasks
@ashwinvaidya17 ashwinvaidya17 moved this to In Progress in Anomalib Apr 4, 2022
@samet-akcay samet-akcay added this to the v0.2.7 milestone Apr 4, 2022
@samet-akcay samet-akcay moved this from In Progress to 🚧 In Progress in Anomalib Apr 4, 2022
@samet-akcay samet-akcay moved this from 🚧 In Progress to 🚀 PR Created in Anomalib Apr 5, 2022
@samet-akcay samet-akcay moved this from 🚀 PR Created to Done in Anomalib Apr 8, 2022
@samet-akcay
Copy link
Contributor

samet-akcay commented Apr 22, 2022 •
edited
Loading

Closing this issue due to DX. Developers preferred to have the task_type parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djdameln djdameln

Labels
Config Enhancement New feature or request
Projects
Anomalib
Archived in project
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Remove task parameter openvinotoolkit/anomalib
3 participants
@samet-akcay @daMichaelB @djdameln