Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pypi_publish.yml to publish_sdist_to_pypi.yml #895

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Mar 27, 2023

Summary

  • The previous work Add publish to PyPI Github action #867 was failed because it try to build wheel on linux. However, PYPI doesn't accept this because https://peps.python.org/pep-0513/.
  • So, we need to just publish the source distribution (sdist) package only, not wheel.
  • Add if-else branching according to tag name for publishing to PyPI or TestPyPI
  • Fix to publish source distribution only
  • Upload source distribution to Github Release page too

How to test

https://github.com/openvinotoolkit/datumaro/actions/runs/4528844180/jobs/7975997071
Upload to TestPyPI failure is because the same filename is not allowed to be uploaded again: pypa/packaging-problems#74

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim marked this pull request as ready for review March 27, 2023 05:37
@vinnamkim vinnamkim added the CI Any changes in CI setting label Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d0aac59) 78.61% compared to head (3a5d829) 78.60%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.1.0     #895      +/-   ##
==================================================
- Coverage           78.61%   78.60%   -0.01%     
==================================================
  Files                 205      205              
  Lines               25067    25067              
  Branches             5029     5029              
==================================================
- Hits                19706    19704       -2     
- Misses               4229     4230       +1     
- Partials             1132     1133       +1     
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 78.60% <ø> (ø)
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim changed the base branch from develop to releases/1.1.0 March 27, 2023 08:23
 - Add if-else branching according to tag name for publishing to PyPI or
TestPyPI
 - Fix to publish source distribution only
 - Upload source distribution to Github Release page too

Signed-off-by: Kim, Vinnam <[email protected]>
@vinnamkim vinnamkim force-pushed the infra/fix-pypi-pipeline branch from 022ed89 to 3a5d829 Compare March 27, 2023 08:28
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit c851c52 into releases/1.1.0 Mar 28, 2023
@vinnamkim vinnamkim deleted the infra/fix-pypi-pipeline branch March 28, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Any changes in CI setting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants