Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong claim format designation in presentation submission #1819

Closed
rmnre opened this issue Jun 17, 2022 · 0 comments · Fixed by #2013
Closed

Wrong claim format designation in presentation submission #1819

rmnre opened this issue Jun 17, 2022 · 0 comments · Fixed by #2013

Comments

@rmnre
Copy link
Contributor

rmnre commented Jun 17, 2022

When issuing a presentation of a W3C verifiable credential, the "format" property in the Input Descriptor Mapping Object of the presentation submission is currently being set to "ldp_vp". It must be set to "ldp_vc" instead, as it refers to the format of the enclosed credential. (See https://identity.foundation/presentation-exchange/spec/v1.0.0/#presentation-submission)

The parts that need to be changed to produce correct presentation submissions are here:
https://github.com/hyperledger/aries-cloudagent-python/blob/4240fa9b192ea4cdb4026211ea4bec694aec5506/aries_cloudagent/protocols/present_proof/dif/pres_exch_handler.py#L1357-L1361

and here (maybe just remove the default entirely?):
https://github.com/hyperledger/aries-cloudagent-python/blob/4240fa9b192ea4cdb4026211ea4bec694aec5506/aries_cloudagent/protocols/present_proof/dif/pres_exch.py#L835-L840

However, verification logic might also need some adaptations when this parameter is changed, I haven't looked into that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant