-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional security controls for webhooks for multi-tenancy #2029
Comments
@andrewwhitehead @ianco @TimoGlastra ^^^ Thoughts on this approach? |
Makes sense to me, if it's a common pattern. For backward compatibility, this should be optional, with a default to the existing "static" api key. Note that the mines team has developed some self-serve functionality for tenants as well, which they've implemented as a plug-in. tagging @usingtechnology |
we can do a prototype of this when we add some enhancements for our tenants in the innkeeper plugin. |
We have a security requirement for tenants to rotate keys for all inbound API calls including webhooks. For webhooks, this would be challenging to manage centrally and is better managed by the tenant. Posting here for feedback on the planned approach before submitting a PR.
The approach is as follows:
This is a pattern used by Github and others to secure webhooks - https://docs.github.com/en/developers/webhooks-and-events/webhooks/securing-your-webhooks
The text was updated successfully, but these errors were encountered: