Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-LD Sign/Verify endpoints do things differently than ICv2/PPv2 #2468

Closed
dbluhm opened this issue Sep 6, 2023 · 0 comments · Fixed by #2533
Closed

JSON-LD Sign/Verify endpoints do things differently than ICv2/PPv2 #2468

dbluhm opened this issue Sep 6, 2023 · 0 comments · Fixed by #2533
Assignees

Comments

@dbluhm
Copy link
Contributor

dbluhm commented Sep 6, 2023

The JSON-LD Sign and Verify endpoints provide a mechanism for doing LDP signatures on JSON-LD documents and verifying signed JSON-LD documents. Issue Credential v2 and Present Proof v2 provide the DIDcomm interface for doing the same when using the ld-proof-detail attachment format. The scope of these components is of course different; however, at some point in the call stack, they should probably be calling the same code for signing and verifying signatures. They do not.

This has the additional side effect that recent updates to add additional Signature Suite types to the JSON-LD signatures are not usable from the sign/verify endpoints.

These endpoints should be updated to use the same underlying calls as ICv2 and PPv2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant