Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-node-exporter-lua: Add support for node_filesystem_* metrics #25535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wjam
Copy link

@wjam wjam commented Dec 11, 2024

Maintainer: @champtar
Compile tested: Lua only, so not compilable
Run tested: TP-Link Archer C7 v2, OpenWrt v23.05 - I've been running the Lua code for a while with no issues and the publicly available Grafana dashboard (https://grafana.com/grafana/dashboards/1860-node-exporter-full/) has been happy with the data

Description:

Add a collector for the various fileystem metrics which matches the node-exporter behaviour. This collector supports the following metrics:

  • node_filesystem_size_bytes
  • node_filesystem_free_bytes
  • node_filesystem_avail_bytes
  • node_filesystem_files
  • node_filesystem_files_free
  • node_filesystem_readonly

Add a collector for the various fileystem metrics which matches the
node-exporter behaviour. This collector supports the following metrics:

* node_filesystem_size_bytes
* node_filesystem_free_bytes
* node_filesystem_avail_bytes
* node_filesystem_files
* node_filesystem_files_free
* node_filesystem_readonly
@wjam
Copy link
Author

wjam commented Dec 11, 2024

Minor comments for @champtar to review:

  • I went with filesytem rather than disk or disk_use which was mentioned in prometheus-node-exporter-lua: Disk space metric #14358 as it matched the node-exporter collector name.
  • As commented in the code, / is excluded as it's an overlay filesystem which does mean the linked Grafana dashboard has a widget showing N/A - which is the same behaviour as node-exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant