Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub title selection should be done according to the language selection #207

Open
kelson42 opened this issue Jun 26, 2024 · 1 comment
Open

Comments

@kelson42
Copy link
Contributor

If I choose "French" in the language selection, automatically the subtitle in French should be chosen. Exception is English (because the soundtrack is in English).

@benoit74
Copy link
Collaborator

Video soundtrack is not necessarily in English, there is few videos in other languages. We need to take this into account.

So the idea is more: whenever a language has been selected in the combobox and stored appropriately thanks to solution implemented in #208, we should automatically activate the matching subtitle in the video player if the video audio is not the selected language and language is available.

@benoit74 benoit74 added this to the 3.1.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants