Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Console Lint and Vulnerabilities #205

Closed
michaelquigley opened this issue Feb 1, 2023 · 1 comment
Closed

Web Console Lint and Vulnerabilities #205

michaelquigley opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
enhancement Enhancement of an existing feature
Milestone

Comments

@michaelquigley
Copy link
Collaborator

See what we can do about the vulnerabilities reported during npm install:

added 1589 packages, and audited 1590 packages in 38s

218 packages are looking for funding
  run `npm fund` for details

11 high severity vulnerabilities

See what we can do about the warnings reported during npm run build:

> [email protected] build
> react-scripts build

Creating an optimized production build...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Compiled with warnings.

[eslint] 
src/console/visualizer/Visualizer.js
  Line 20:8:  React Hook useEffect has missing dependencies: 'networkGraph' and 'props'. Either include them or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useEffect call and refer to those specific props inside useEffect  react-hooks/exhaustive-deps
  Line 26:8:  React Hook useEffect has a missing dependency: 'networkGraph'. Either include it or remove the dependency array                                                                                                                                                                                                                  react-hooks/exhaustive-deps

src/register/Register.js
  Line 33:8:  React Hook useEffect has a missing dependency: 'token'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

src/resetPassword/ResetPassword.js
  Line 6:13:  'search' is assigned a value but never used  no-unused-vars

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

File sizes after gzip:

  740.98 kB  build/static/js/main.391de7fe.js
  827 B      build/static/css/main.ddc97b8b.css

The bundle size is significantly larger than recommended.
Consider reducing it with code splitting: https://goo.gl/9VhYWB
You can also analyze the project dependencies: https://goo.gl/LeUzfb
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Feb 1, 2023
@michaelquigley michaelquigley added this to the v0.3 milestone Feb 1, 2023
@camotts
Copy link
Contributor

camotts commented Feb 2, 2023

One vuln we are not going to be able to solve:

GHSA-9vvw-cc9w-f27h

debug  <2.6.9
Severity: high
debug Inefficient Regular Expression Complexity vulnerability - https://github.com/advisories/GHSA-9vvw-cc9w-f27h
No fix available
node_modules/aframe/node_modules/debug
  aframe  >=0.6.0
  Depends on vulnerable versions of debug
  node_modules/aframe
    3d-force-graph-vr  >=1.4.3
    Depends on vulnerable versions of aframe
    node_modules/3d-force-graph-vr
      react-force-graph  *
      Depends on vulnerable versions of 3d-force-graph-vr
      node_modules/react-force-graph

Will need the react-force-graph library to update it's deps

@camotts camotts moved this from Backlog to Development in zrok Development Roadmap Feb 2, 2023
@camotts camotts moved this from Development to Evaluating in zrok Development Roadmap Feb 6, 2023
@michaelquigley michaelquigley moved this from Evaluating to Done in zrok Development Roadmap Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Development

No branches or pull requests

2 participants