Skip to content

Commit

Permalink
ci: bump npm to version 7 (apache#16748)
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro authored and Emmanuel Bavoux committed Nov 14, 2021
1 parent b4499e1 commit 9f1dea8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/bashlib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ npm-install() {
cd "$GITHUB_WORKSPACE/superset-frontend"

# cache-restore npm

say "::group::Install npm@7"
sudo npm i -g npm@7 --registry=https://registry.npmjs.org
say "::group::Install npm packages"
echo "npm: $(npm --version)"
echo "node: $(node --version)"
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci_check_no_file_changes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ do
REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)"
echo "Searching for changes in python files"
elif [[ ${CHECK} == "frontend" ]]; then
REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)"
REGEX="(^\.github\/workflows\/.*(bashlib|frontend|e2e)|^superset-frontend\/)"
echo "Searching for changes in frontend files"
else
echo "Invalid check: \"${CHECK}\". Falling back to exiting with FAILURE code"
Expand Down

0 comments on commit 9f1dea8

Please sign in to comment.