Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: msbuild failed with exit code: 1 #766

Closed
rhali786 opened this issue Oct 6, 2017 · 4 comments
Closed

Error: msbuild failed with exit code: 1 #766

rhali786 opened this issue Oct 6, 2017 · 4 comments

Comments

@rhali786
Copy link

rhali786 commented Oct 6, 2017

Node: v7.9.0
oracledb: 1.13.1
Oracle Client from Website. Installed through windows installer.
Oracle Database version unknown
OS : Win 7
Compiler : VS 2015 MSBuild.exe
ENV Vars: set through System Properties Screen
-OCI_INC_DIR=C:\Oracle\instantclient\sdk\include
-OCI_LIB_DIR=C:\Oracle\instantclient\sdk\lib\msvc

As Admin I am trying to run npm install -s oracledb from within my project.

Errors:

c:\users\rhali\.node-gyp\7.9.0\include\node\v8.h(18): fatal error C1083: Cannot open include file: 'stddef.h': No such file or directory (compiling source file ..\src\njs\src\njsConnection.cpp) [C:\apps\my-proof-of
-concepts\git_oracledb\node-oracledb\build\oracledb.vcxproj]

I've run with silly for more details. I've been through node-gyp code, I've updated applications.
I need to use VS2015 and can't uninstall it because it's necessary for other projects.

The necessary include files are located here: C:\Program Files (x86)\Windows Kits\10\Include\10.0.10150.0\ucrt

By changing the vcxproj file I can get past this error. Which leads to a new error about libraries which are located here: C:\Program Files (x86)\Windows Kits\10\Lib\10.0.10150.0\ucrt\x64

If I add this code to the vcxproj then it will compile properly.

Editing the vcxproj file isn't a solution because it's built dynamically from binding.gyp.

I tried to add the directories to the gyp file, but I get hexadecimal errors when I try this.

C:\apps\my-proof-of-concepts\git_oracledb\node-oracledb\build\oracledb.vcxproj(49,281): error MSB4025: The project file could not be loaded. ', hexadecimal value 0x08, is an invalid character. Line 49, position 2
81.

Maybe I'm missing a better way to use UniversalCRT for VS2015 MSBuild or I need to learn how to edit a gyp file better.

Any assistance greatly appreciated.

@rhali786
Copy link
Author

rhali786 commented Oct 7, 2017

Hi @cjbj, i've seen you add some good value on a lot of issues. I've been reading a number of them trying to see if this has vexed any one else.

Do you think you could take a look and tell me if anything stands out ?

Thanks!

@cjbj
Copy link
Member

cjbj commented Oct 9, 2017

@rhali786 Check #18. Also some users have reported success with the windows-build-tools package.

When I get back from vacation, I'm going to sit down with @dmcghan and work on the issue of reliable packaging for prebuilt binaries.

@rhali786
Copy link
Author

rhali786 commented Oct 9, 2017

@cjbj thank you for your reply. I considered trying Oracle-pb my concern was having a dependency on a different package. So if there is an important update in the original Oracle db would I be having an issue with the Oracle pb?

Windows build tools is awesome, I suggest this for my developers that don't have visual studio previously installed. Though the compiler will not install if visual studio is already installed.

@cjbj
Copy link
Member

cjbj commented Nov 21, 2017

@rhali786 keep tracking #18 and give comments on the proposal. This is the best way to move forward.

@cjbj cjbj closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants