Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inscription charms #2565

Closed
casey opened this issue Oct 20, 2023 · 3 comments · Fixed by #2681
Closed

Add inscription charms #2565

casey opened this issue Oct 20, 2023 · 3 comments · Fixed by #2681
Labels
enhancement

Comments

@casey
Copy link
Collaborator

casey commented Oct 20, 2023 •
edited
Loading

Inscription charms are anything that make an inscription special. These include:

  • Each curse is a different spooky charm
  • Being on an uncommon or better sat
  • Being on a block 9 sat

Each charm is an emoji, and should be displayed on the inscription page.
@lifofifoX
Copy link
Collaborator

Would you be open to showing the sequence number just for cursed inscriptions, making it easier to discover where the inscription fits into the timeline?

@raphjaph
Copy link
Collaborator

raphjaph commented Nov 8, 2023

I think they should stay for internal use only for now. If we add them they should be display everywhere.

@lifofifoX
Copy link
Collaborator

@raphjaph Fair enough 👍

@casey casey changed the title Make cursed inscriptions a little bit shinier Add charms Nov 13, 2023
@casey casey changed the title Add charms Add inscription charms Nov 13, 2023
@casey casey linked a pull request Nov 16, 2023 that will close this issue
Add inscription charms #2681
Merged
@casey casey removed a link to a pull request Nov 16, 2023
Add inscription charms #2681
Merged
@casey casey linked a pull request Nov 16, 2023 that will close this issue
Add inscription charms #2681
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inscription charms casey/ord
3 participants
@casey @raphjaph @lifofifoX