Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inscriptions with unrecognized even tag will be bound after jubilee #2845

Closed
veryordinally opened this issue Dec 10, 2023 · 3 comments · Fixed by #2894
Closed

New inscriptions with unrecognized even tag will be bound after jubilee #2845

veryordinally opened this issue Dec 10, 2023 · 3 comments · Fixed by #2894

Comments

@veryordinally
Copy link
Collaborator

The current implementation in inscription_updater.rs would cause new inscriptions made with unrecognized even tags bound after the jubilee:

let unbound = current_input_value == 0 || curse == Some(Curse::UnrecognizedEvenField);

This should probably be changed to not test for the curse, but test for the presence of an unrecognized even field.

@casey
Copy link
Collaborator

casey commented Dec 23, 2023

Damn, nice catch!

@lgalabru
Copy link

lgalabru commented Jan 5, 2024

Why is this Curse::UnrecognizedEvenField a particular case?
I don't understand why this curse is being considering as unbound in a first place.
unbound was introduced for handling supertestnet transactions (inputs = outputs = 0), why mixing this states?

@casey
Copy link
Collaborator

casey commented Jan 5, 2024

Treating even fields as special has actually be planned from the beginning, although it wasn't well explained.

The idea is this: We might want to add fields that change the way that inscriptions are created or transferred. However, we want to avoid a situation where un-upgraded versions of ord and upgraded versions of ord disagree about the location or existence of inscriptions. Because, we don't want someone to be able to trick an old version of ord into thinking they have an inscription, when in fact they don't. So, to avoid this, we make inscriptions with unrecognized even fields see those inscriptions as unbound, or not having any location. Odd fields don't affect whether inscriptions exist or how they transfer, so unrecognized odd fields can be ignored by un-upgraded clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants