Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to restore wallet in ord 0.16.0-rc1 #3225

Closed
so7ow opened this issue Mar 6, 2024 · 7 comments · Fixed by #3237
Closed

Unable to restore wallet in ord 0.16.0-rc1 #3225

so7ow opened this issue Mar 6, 2024 · 7 comments · Fixed by #3237
Labels

Comments

@so7ow
Copy link

so7ow commented Mar 6, 2024

I am unable to restore a known-good ord wallet using the 0.16.0-rc1 version of ord.

 $ ./ord --version
ord 0.16.0-rc1

I start a server:

 $ ./ord server --http-port 8000
Listening on http://0.0.0.0:8000

I leave that running and execute this in another window:

 $ ./ord wallet --name TEST123 --server-url http://127.0.0.1:8000 restore --from mnemonic

...and then I get a cursor on the new line. I assume I am supposed to type in my space-separated mnemonic here, on one line? When I do, and press enter, the cursor advances to the next line and then nothing happens. Am I doing something wrong, or is this broken?

Restoring the same wallet in ord 0.15.0 works fine:

 $ ./ord --version
ord 0.15.0

 $ ./ord wallet --name TEST1234 restore "phrase redacted phrase redacted phrase redacted phrase redacted phrase redacted phrase redacted"
{}
@so7ow
Copy link
Author

so7ow commented Mar 6, 2024

I also just tried entering the mnemonic one word per line. That didn't work either.

@bingryan
Copy link
Contributor

bingryan commented Mar 7, 2024

io::stdin().read_to_string(&mut buffer)?;

for read_to_string , when you input end In the terminal, you can input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems) .

@bingryan
Copy link
Contributor

bingryan commented Mar 7, 2024

@so7ow for your example:

 $ ./ord wallet --name TEST123 --server-url http://127.0.0.1:8000 restore --from mnemonic

after input your mnemonic, you must input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems).

@bingryan
Copy link
Contributor

bingryan commented Mar 7, 2024

@raphjaph BTW, Is io::stdin(). read_line(&mut buffer)? a better choice instead of io::stdin().read_to_string(&mut buffer)?;

@so7ow
Copy link
Author

so7ow commented Mar 7, 2024

Thank you, I'll give that a try. If that's truly required, some notice to the user would seem to be in order!

@so7ow
Copy link
Author

so7ow commented Mar 7, 2024

@so7ow for your example:

 $ ./ord wallet --name TEST123 --server-url http://127.0.0.1:8000 restore --from mnemonic

after input your mnemonic, you must input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems).

That worked! 👍🏻

@raphjaph raphjaph added the bug label Mar 7, 2024
@raphjaph raphjaph added this to Tracker Mar 7, 2024
@raphjaph raphjaph moved this to In Progress in Tracker Mar 7, 2024
@raphjaph
Copy link
Collaborator

raphjaph commented Mar 7, 2024

I've fixed this and written some documentation in #3237

Thank you for bringing this up to my attention!

@raphjaph raphjaph moved this from In Progress to Ready for Review in Tracker Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants