Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression via content-encoding #891

Closed
casey opened this issue Dec 6, 2022 · 5 comments · Fixed by #1366
Closed

Add compression via content-encoding #891

casey opened this issue Dec 6, 2022 · 5 comments · Fixed by #1366

Comments

@casey
Copy link
Collaborator

casey commented Dec 6, 2022

We should add a field to inscriptions which contains a text string which is served with resources as the content-encoding header value. Users can then apply compression which should lead to a nice size reduction for lots of kinds of content. The command line tools should automatically apply compression if it results in a size decrease.

Brotli is well supported and very good, so we can use that: https://caniuse.com/?search=brotli

@casey casey added this to the Production Inscriptions milestone Dec 6, 2022
@casey casey mentioned this issue Dec 6, 2022
7 tasks
@casey casey modified the milestones: Mainnet Inscriptions, Later Dec 14, 2022
@casey casey removed this from the Later milestone Dec 23, 2022
@raphjaph raphjaph added this to the Beta milestone Jan 19, 2023
@casey casey removed this from the Beta milestone Jan 22, 2023
@casey casey closed this as completed Jan 25, 2023
@casey casey reopened this Feb 6, 2023
@staccDOTsol
Copy link

@staccDOTsol
Copy link

ha. it appears you'd already merged this 2 months ago and didn't clear the to-do item here.

Lmk if anything in my pr is useful

@tyjvazum
Copy link

This issue is still open because compression still isn't supported. PR https://github.com/casey/ord/pull/1713 was worked on to implement support for Brotli. PR https://github.com/casey/ord/pull/1366 only involves the block explorer website code.

@nammaki
Copy link

nammaki commented Mar 23, 2023

I really want compression 🙏

@casey
Copy link
Collaborator Author

casey commented Nov 30, 2023

This is done in #1713 although keep in mind that there is a cloudflare bug which prevents this from working #2775.

@casey casey closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants