Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDL Refactor #21

Open
ryanpdx opened this issue Feb 18, 2024 · 0 comments
Open

EDL Refactor #21

ryanpdx opened this issue Feb 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ryanpdx
Copy link
Member

ryanpdx commented Feb 18, 2024

Currently it is harder to add or edit an EDL command it is both defined in protocols/edl_command.py and in the services/edl.

It would be great to have an object that has the definition of how the request packet, response packet, and a run() method all in one location for each command.

Proposed new Order of operations:

  • EDL Service get a new request packet from the Radio Service
  • EDL Service unpack and validates request packet with protocols and protocols returns a command obj(?)
  • EDL Service run the command object
  • EDL Service sends the command object back to protocols to pack the response packet
  • EDL Service sends response packet to Radio Service

The key to this is having one place that defines all uses of the command.

@ryanpdx ryanpdx added the enhancement New feature or request label Feb 18, 2024
@ryanpdx ryanpdx moved this from Todo to In Progress in Space Segment Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Implementing
Development

No branches or pull requests

2 participants