Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use {data-id} on notice #46

Closed
joaomfantunes opened this issue Oct 12, 2023 · 4 comments
Closed

Use {data-id} on notice #46

joaomfantunes opened this issue Oct 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@joaomfantunes
Copy link

In one use case, it was necessary to pass the {data-id} variable within the printed message, and this variable was not rewritten by the token.
After analyzing the code, this update was possible by changing one line of code (line 568) to this:
notice && notice_text.insertAdjacentHTML('beforeend', noticeText.replaceAll(DATA_ID_PLACEHOLDER, serviceProp._id) || '');
Right now the code is working.

@Nantiee
Copy link

Nantiee commented Mar 29, 2024

I need the same feature actually.
It would be very useful !

@orestbida orestbida added enhancement New feature or request and removed triage labels Apr 1, 2024
@orestbida
Copy link
Owner

Can be done!

@streiten
Copy link

streiten commented Sep 6, 2024

Can be done!

will it be done ;-) ?

@orestbida
Copy link
Owner

@streiten yep ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants