Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong icon used for amenity=waste_disposal #1839

Closed
pastk opened this issue Jan 12, 2022 · 4 comments · Fixed by #1868
Closed

Wrong icon used for amenity=waste_disposal #1839

pastk opened this issue Jan 12, 2022 · 4 comments · Fixed by #1868
Assignees
Labels
Classificator Classify object by types Icons Map and app icons

Comments

@pastk
Copy link
Member

pastk commented Jan 12, 2022

amenity=waste_disposal is used for general rubbish going to landfills ("A medium or large disposal bin, typically for bagged up household or industrial waste.")
However at the moment its displayed using recycling icon which is wrong and confuses people (who expect to find e.g. separate collection of recyclable stuff there).
Current icon:

bin_recycling

Please change it to the trash bin icon used for amenity=waste_basket:

bin_trash

@biodranik biodranik added Bug Something isn't working Icons Map and app icons Map Data OpenStreetMap data related issues labels Jan 12, 2022
@vng vng added Classificator Classify object by types and removed Bug Something isn't working Map Data OpenStreetMap data related issues labels Jan 13, 2022
@vng
Copy link
Member

vng commented Jan 13, 2022

Well, seems like current OM approach for recycling is obsolete and needs to be reviewed.

See https://taginfo.openstreetmap.org/tags/amenity=recycling#combinations

  • recycling_container is obsolete
  • not sure that recycling classificator subtypes are correctly parsed
  • should make big icon like waste basket

@vng
Copy link
Member

vng commented Jan 13, 2022

Probably, can find some interesting things here: mapsme/omim#13450

@pastk
Copy link
Member Author

pastk commented Jan 13, 2022

E.g. recycling:aluminium_cans=yes and recycling:pet_drink_bottles=yes are not recognized by OM at the moment.

@pastk
Copy link
Member Author

pastk commented Jan 18, 2022

I just noticed that landuse=landfill uses recycling icon also.
A trash bin icon won't be perfect but better than the current one anyway.
Another option is to display no icon at all, but just a "Landfill" text when its zoomed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Classificator Classify object by types Icons Map and app icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants