You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pull_request_review correctly triggers when a PR review is submitted. However, IMO incorrectly it also triggers when one adds a reply comment to a PR conversations, but without submitting a review.
E.g. I added this comment, which triggered this run, and when I added this comment, this run started. In both cases, I did not submit a review, i.e. I did not click this button:
I was just adding comments, directly and immediately, while there were no review comments pending.
pull_request_review_comment is specifically the opposite of what I need.
This is my bug report here. I followed the documented procedure to raise a bug report for GitHub Actions. If I don't get any reply from GitHub for some time here, I'll also try to get in touch with their support.
I don't think runners have anything to do with the triggers. GitHub calls the runners when a workflow is triggered, so at that point it's already too late.
Also, not to offend you, but did you write your answer with a LLM? Because it feels very much like it, including that while it's long, detailed, and plausibly sounding, it doesn't really help. I appreciate the intent, though, and thank you.
BugSomething isn't working correctlyActionsBuild, test, and automate your deployment pipeline with world-class CI/CD
2 participants
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Select Topic Area
Bug
Body
In this workflow, these are the triggers:
pull_request_review
correctly triggers when a PR review is submitted. However, IMO incorrectly it also triggers when one adds a reply comment to a PR conversations, but without submitting a review.E.g. I added this comment, which triggered this run, and when I added this comment, this run started. In both cases, I did not submit a review, i.e. I did not click this button:
I was just adding comments, directly and immediately, while there were no review comments pending.
The docs are explicit that this is the behavior of
pull_request_review_comment
instead, so this seems to be a bug to me.Beta Was this translation helpful? Give feedback.
All reactions