Support for Jupyter Notebooks in code reviews

[gabroo]

Currently in PRs, when viewing files with the .ipynb extension, they are displayed only in the raw JSON representation, which makes it essentially useless for conducting code reviews. The line numbers don't align with the notebook, there's no syntax highlighting, all the metadata is viewable, etc.

It would be amazing to have the files rendered in the familiar notebook format with cells.

Ideally, it would be nice to also have support for rendering interactive cell outputs (ie, not just static images), but at a minimum, adding comments to notebooks in the cell format should be supported.

Is this on your radar? If so, is there any kind of timeline for this?

I would assume this a huge pain point for many data science teams that would like to use GitHub for source control, but simply cannot because their go-to file format is unsupported in code reviews.

[gaow]

I echo this feature request. Currently I rely on this 3rd party service.

[Tobeyforce]

Same, as someone doing code reviews for university students (with github classroom) I can't give proper feedback on notebooks.

[serghiou]

For an academic setting you may want to consider Colab. Students can start coding with zero setup, easily import any pre-work you may have done and available on GitHub, and you can comment on any of their code as if commenting in Google Docs.

[therzka]

@Tobeyforce @gaow @gabroo

👋 We've just opened up a feature preview for diffing Jupyter Notebooks, please fill out this form for access and provide feedback in this discussion

[ostegm]

I signed up, but have not gotten access, is this feature still available to preview?

[ruthappel]

Hi @therzka, thanks a lot for creating the feature preview – I signed up a few days ago, but don't seem to have gotten access yet. Is it still available?

[therzka]

@ruthappel @ostegm this feature is now an official feature preview that you can enable for yourself! (click on your avatar and then on feature previews)

[ruthappel]

Thank you so much @therzka, this is great :)

[miaojingang]

@therzka Do you know when the preview will be available in github enterprise?

[smith-kyle]

Not sure what the timeline is for this feature to be finished, but in the meantime you can use GitNotebooks. It's free for private repos.

Just a little friendly competition 😛

[Paul1911]

Hey @ruthappel, thank you for taking this up :) I was just wondering - what is the official timeline for going out of testing into production? We could really need it at work, but as we don't have access to feature previews, we can't make use of it atm.

[nathanneuro]

any news on this?

[droumis]

any update? where is this on the roadmap?

[princelySid]

You can enable this in Feature preview, found by clicking your picture in the top right.