GitHub Community
Persist "Hide whitespace" preference across PRs #65597
Replies: 22 comments 11 replies
-
|
Note that this proposal already has a lot of support in the older thread: https://github.com/orgs/community/discussions/5486 |
Beta Was this translation helpful? Give feedback.
-
|
Personally I believe it would be even better if it was possible to set per filetype, as not ALL filetypes has whitespaces as pure cosmetics. But ignoring whitespaces should also be coupled with not seeing solo { and } with a particular indentation as a good match for synchronisation. that causes bad syncs for e.g. C# and similar. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, please add this, at least on a per-user level. |
Beta Was this translation helpful? Give feedback.
-
|
At a minimum, the "Show Whitespace" toolbar button should always be visible. It shouldn't be markedly easier to show whitespace than to hide it.
|
Beta Was this translation helpful? Give feedback.
-
|
THIS HERE! 🙏🏼 |
Beta Was this translation helpful? Give feedback.
-
|
Reviewing code is a BIG part of the time i spend on github. Hiding whitespace is such a vital feature, i don't unterstand how this cannot be a priority. You already have the functionality, just persist it 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
My workflow literally involves manually turning on this flag on every single PR I do, because the vast majority of files I review the white-space does not matter. |
Beta Was this translation helpful? Give feedback.
-
|
It's amazing that a website literally for computer programmers can cause so much disruption in a programmer's flow. Please add this as a persistent option, it is annoying and slows me down having to check it every time. |
Beta Was this translation helpful? Give feedback.
-
|
One more vote to please oh please make this a persistent user-level (and/or repo-level) setting! It's quite rare that whitespace changes matter in our workflows; swapping the default to ignore it, would save so much time. |
Beta Was this translation helpful? Give feedback.
-
|
A friend directed me to this as an interim solution: https://chromewebstore.google.com/detail/git-well-soon/ehpeaofieafibmhiagianfjjblpnmbdo I.e. A chrome plugin that does exactly what we want! |
Beta Was this translation helpful? Give feedback.
-
|
Great workaround! Thanks for sharing! |
Beta Was this translation helpful? Give feedback.
-
|
A dev could literally implement this in a day at max. Now imagine how many human work hours are wasted by developers coming here to read through this thread, vote, and comment. |
Beta Was this translation helpful? Give feedback.
-
|
My guess would be that it is not the work load of the hack that is the issue.... IMHO implementing it as suggested surely would be better than what we have currently for many (including me), but really would be a inadequate hack/workaround for a deeper problem in For the code part of say a .cs file spaces/indentions would be purely cosmetic, but inside a string value in the same file they might be important, with undesired nasty side effects, and thus not ignorable. and really ought to be visible to a reviewer, to catch a crucial system breaking typo! So to do a logical diff without risk of false positives or false negatives some 'compiling' would be needed to decode each file into its logical components, including first detecting its programming language correctly (relying on the file extension might not be enough), before a compare can be safely done. ...And next comes thinking up a clever way of actually displaying the found logical differences between two files that char by char seems very different, but are close to logically identical (as we currently have it with spaces, but could be different line splittings as well) So certainly not something pulled off in a single day.... |
Beta Was this translation helpful? Give feedback.
-
The functionality exists already. The only thing being asked is for a users to be able to have their preference to have it ON by default be remembered. |
Beta Was this translation helpful? Give feedback.
-
|
@drwharris, Did you even read what I wrote, and what it was a comment to? |
Beta Was this translation helpful? Give feedback.
-
|
I did and you have a valid point, however I use this existing functionality a lot and I use it knowing these limitations. And while a small inconvenience, I would like the option to default it to on. |
Beta Was this translation helpful? Give feedback.
-
|
So you might have noticed that I started by saying that it for me too would be better than what we got now.... |
Beta Was this translation helpful? Give feedback.
-
|
Please implement this. The previous thread has many comments. I heard devs complaining about this 3 years ago. It's 2024 and you have the backing of Microsoft. Please implement this. |
Beta Was this translation helpful? Give feedback.
-
|
This would be amazing to have! How can we get this feature prioritized? I find myself reviewing large PRs way too often, only to realize that its 95% whitespace changes. My company has strict policies on chrome extensions so that is not a viable option unfortunately. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on request for this user-level setting to be added. |
Beta Was this translation helpful? Give feedback.
-
|
This is one of the most annoying daily things I do (and that says a LOT) so please please prioritize 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Yet another request for this. I've written my own AppleScript to add (AppleScript below if anyone wants it. I use the excellent FastScripts to give it a keyboard shortcut.) tell application "Safari"
set currentDoc to front document
set theWindow to window 1 where its document is currentDoc
tell (current tab of theWindow)
set URL to URL & "?w=1"
end tell
end tell |
Beta Was this translation helpful? Give feedback.
-
|
Another workaround is to use the Requestly browser extension to automatically add Here's my rule file that can be Imported into Requestly: [
{
"creationDate": 1586890092492,
"description": "Hide whitespace changes",
"groupId": "",
"id": "QueryParam_1586890092492",
"isSample": false,
"name": "Whitespace",
"objectType": "rule",
"pairs": [
{
"modifications": [
{
"actionWhenParamExists": "Overwrite",
"param": "w",
"type": "Add",
"value": "1"
}
],
"source": {
"filters": {},
"key": "Url",
"operator": "Wildcard_Matches",
"value": "*github.com/*/files*"
}
},
{
"modifications": [
{
"actionWhenParamExists": "Overwrite",
"param": "w",
"type": "Add",
"value": "1"
}
],
"source": {
"filters": {},
"key": "Url",
"operator": "Wildcard_Matches",
"value": "*github.com/*/files/*..*"
}
},{
"modifications": [
{
"actionWhenParamExists": "Overwrite",
"param": "w",
"type": "Add",
"value": "1"
}
],
"source": {
"filters": {},
"key": "Url",
"operator": "Wildcard_Matches",
"value": "*github.com/*/commits/*"
}
},
{
"modifications": [
{
"actionWhenParamExists": "Overwrite",
"param": "w",
"type": "Add",
"value": "1"
}
],
"source": {
"filters": {},
"key": "Url",
"operator": "Wildcard_Matches",
"value": "*github.com/*/commit/*"
}
},
{
"modifications": [
{
"actionWhenParamExists": "Overwrite",
"param": "w",
"type": "Add",
"value": "1"
}
],
"source": {
"filters": {},
"key": "Url",
"operator": "Wildcard_Matches",
"value": "*github.com/*/compare/*"
}
}
],
"ruleType": "QueryParam",
"status": "Active"
}
] |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for sharing! This feels safer to me than the other extension going around :) |
Beta Was this translation helpful? Give feedback.
-
|
+1 this worked great for me, thanks for sharing! |
Beta Was this translation helpful? Give feedback.
-
|
I cannot believe we still don't have it. Every day, every review, I have to manually enable hide whitespace. It's so annoying! |
Beta Was this translation helpful? Give feedback.
-
|
+1 please implement this. |
Beta Was this translation helpful? Give feedback.
-
|
Would really like this feature, please! GitKraken has it, so why not GitHub? :) |
Beta Was this translation helpful? Give feedback.
-
|
Because they're different companies with different codebases, just like GH has PR change suggestions that you can apply but BitBucket has not 😏 But honestly GH already has PR level whitespace hiding toggle, doubt it's that hard to add a global one that works as a default for the PR level... |
Beta Was this translation helpful? Give feedback.
-
|
Been waiting for this feature for years. Please add it! |
Beta Was this translation helpful? Give feedback.
-
|
I continue to get halfway through a PR review, to scroll back to the top, to check "Hide whitespace changes" - and then scroll back down to where I was in my review. |
Beta Was this translation helpful? Give feedback.
-
|
It's been years since the original request was made, and 1 year since this discussion was made, lots of attention (almost 225 at this point), and yet no user level solution, is there anyone we can tag that could give us a status update on this? |
Beta Was this translation helpful? Give feedback.
-
|
It would be very useful. I am migrating from Gitlab and missing this feature. |
Beta Was this translation helpful? Give feedback.
and others
-
Select Topic Area
Product Feedback
Body
Hey team, thanks for all your hard work!
What are your thoughts on persisting the "Hide whitespace" preference in diff view settings across PRs, as the Unified/Split preference is persisted? I pretty much turn "Hide whitespace" on for every diff I look at, so it'd be nice to only ever do that once :)
Upon searching for similar discussions, I found an older thread that mentioned that this setting is intended to store your preference per-diff. To maintain that functionality, "Hide whitespace" could be added as a user-level setting, defaulting to that value when looking at a PR for the fist time, then still allowing it to be set a t a per-diff level on the diff itself.
Thanks for considering!
Beta Was this translation helpful? Give feedback.
All reactions