add preserve_path option for cookie session to not override the path #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#296
Proposed changes
This adds a
preserve_path
option to thecookie_session
authenticator to allow the original path specified to be used to check the sessionChecklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
developer guide (if appropriate)
Further comments
You can configure as follows:
With
preserve_path
set totrue
, all session check calls will go to the path specified in thecheck_session_url
rather than replacing itI'm not in love with the parameter name, but it's the first thing that came to mind (except using
override_path
instead, but I don't want to change the default behavior)I'm also thinking that the original request path should be preserved somewhere when this is set, either as a query param (
https://example.com/check-session?path=/original/path
) or as a header (X-Oathkeeper-Original-Path: /original/path
). Thoughts on that?