Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mutator/id_token): fix token expiration error in tests #390

Merged
merged 1 commit into from
Mar 29, 2020
Merged

fix(mutator/id_token): fix token expiration error in tests #390

merged 1 commit into from
Mar 29, 2020

Conversation

kaorimatz
Copy link
Contributor

Related issue

CI test for #389: https://circleci.com/gh/ory/oathkeeper/3986

Proposed changes

  • Configure the TTL only if it is greater than 0 (the zero value of time.Duration) to avoid "Token is expired" error.
  • Fix an assert for the exp claim. The default TTL is 15 minutes.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@aeneasr
Copy link
Member

aeneasr commented Mar 29, 2020

Thank you!

@aeneasr aeneasr merged commit 9c07a73 into ory:master Mar 29, 2020
@kaorimatz kaorimatz deleted the fix-mutator-id-token-fix-token-expiration-error-in-tests branch March 29, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants