Don't copy the decission endpoint request's Content-Length #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marlinc
force-pushed
the
decission-content-length
branch
from
14951a1 to
3cc22d4
Compare
Marlinc
changed the title
We currently copy all original request headers send to the decission endpoint back. This can include the Content-Length header which describes the request body or response. Including the original request Content-Length causes issues for the decission endpoint client if the response body doesn't match the exact size. This change makes sure the Content-Length doesn't get included in the response body and adds a test to prevent future regressions.
Marlinc
force-pushed
the
decission-content-length
branch
from
3cc22d4 to
e5505ea
Compare
|
Thanks! |
|
Is this issue really solved? I have the same problem: the "Content-Length" of the request and the response are the same, even when the response has an empty body. EDIT: I found the error. I'll create a pull request to fix it :) |
flusflas
added a commit
to flusflas/oathkeeper
that referenced
this pull request
Sep 29, 2020
Issue ory#422 didn't fix the problem with the requests' Content-Length being copied in the responses because the check was case-sensitive and unit tests didn't cover it.
flusflas
added a commit
to flusflas/oathkeeper
that referenced
this pull request
Sep 29, 2020
Issue ory#422 didn't fix the problem with the requests' Content-Length being copied in the responses because the check was case-sensitive and unit tests didn't cover it.
aeneasr
pushed a commit
that referenced
this pull request
Sep 30, 2020
Issue #422 didn't fix the problem with the requests' Content-Length being copied in the responses because the check was case-sensitive and unit tests didn't cover it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently copy all original request headers send to the decission
endpoint back. This can include the Content-Length header which
describes the request body or response. Including the original
request Content-Length causes issues for the decission endpoint
client if the response body doesn't match the exact size.
Proposed changes
This change makes sure the Content-Length doesn't get included in
the response body and adds a test to prevent future regressions.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments