Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matcher.Match handles nil *url.URL #485

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

err0r500
Copy link
Contributor

Related issue

Should fix issue #484

Proposed changes

Just add a check for nil *url.URL in RepositoryMemory.Match

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2020

CLA assistant check
All committers have signed the CLA.

@err0r500 err0r500 changed the title matcher.Match handles nil *url.URL fix: matcher.Match handles nil *url.URL Jul 28, 2020
@aeneasr
Copy link
Member

aeneasr commented Jul 29, 2020

Thank you!

@aeneasr aeneasr merged commit ab27dda into ory:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants