-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Read windows path error #514
Conversation
this issue is happened on windows 10 system,it may cased by incorrect string parse with url.Parse() method .that split string with ' : ',and make it wrong . The error message is as follows: time="2020-01-08T15:43:39+08:00" level=error msg="Unable to update access rules from given location, changes will be ignored. Check the configuration or restart the service if the issue persists." error="parse file://\F:\aweso meProject\bin\resource-server.json: invalid port ":\\awesomeProject\\bin\\resource-server.json" after host" file="file:///F:/awesomeProject/bin/resource-server.json"
just delete pieces of code
if you need this fix ,just test and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, given that this changeset removes a check and does not introduce new tests demonstrating the effectiveness and potential regressions, could you please add them so that we know this does what it is supposed to do? Thank you!
Sorry ,I am not free to give you a test example. That error caused by parse twice ,you can test with any URL likes |
Ok, I will have to check this on a windows machine. But without tests, this can't unfortunately be merged :/ |
this issue is happened on windows 10 system,it may cased by incorrect string parse with url.Parse() method .that split string with ' : ',and make it wrong . The error message is as follows:
time="2020-01-08T15:43:39+08:00" level=error msg="Unable to update access rules from given location, changes will be ignored. Check the configuration or restart the service if the issue persists." error="parse file://\F:\aweso
meProject\bin\resource-server.json: invalid port ":\awesomeProject\bin\resource-server.json" after host" file="file:///F:/awesomeProject/bin/resource-server.json"
Related issue
Proposed changes
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments