Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add url_param config option to redirect error handler. #520

Merged
merged 15 commits into from
Sep 21, 2020
Merged

feat: add url_param config option to redirect error handler. #520

merged 15 commits into from
Sep 21, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 21, 2020

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

marcinkoziej and others added 15 commits September 21, 2020 09:18
@marcinkoziej @aeneasr
errors: Add url_param config option to redirect error handler.
3b91ca7 
This change introduces a url_param config option for redirect error handler.
If it contains a url paramter name, the redirect url will have this parameter
set, containing the current url (from which Oathkeeper has redirected the user).

This can be useful in passing the return_to url to Kratos, so user can be
redirected to the page they initially wanted to access after a successfull sign in.
@marcinkoziej @aeneasr
Run the gofmt -w to make linter happy
9dcf366
@marcinkoziej @zepatrik @aeneasr
Fix golang style issues
87c4f73 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Fix golang style issues
36eb2ff 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Fix golang style issues (local var names)
3013aa2 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Fix golang style issues
a915c25 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Fix golang style issues
64dbd3e 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Fix test so it does not discard error
fc67032 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Update pipeline/errors/error_redirect.go
afa0004 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @zepatrik @aeneasr
Update pipeline/errors/error_redirect.go
4374f2a 
Co-authored-by: Patrik <[email protected]>
@marcinkoziej @aeneasr
Fix typo in test: request.NoErr -> request.NoError
9e71d31
@marcinkoziej @aeneasr
Modify return_to_query_param description
ddd79a2 
Co-authored-by: hackerman <[email protected]>
@marcinkoziej @aeneasr
Change url_param to return_to_query_param
76a8567
@marcinkoziej @aeneasr
Document return_to_query_param
8e0f27f
@aeneasr
Merge branch 'master' into fixthestatusquo-feature/pass_url_in_redirect
31f5d51
@aeneasr aeneasr merged commit b5bb3bc into master Sep 21, 2020
@aeneasr aeneasr deleted the fixthestatusquo-feature/pass_url_in_redirect branch September 21, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeneasr @marcinkoziej