Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added more tests in error_redirect_test.go #522

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

xlanor
Copy link
Contributor

@xlanor xlanor commented Sep 25, 2020

Proposed changes

With the inclusion of the new url_param config option to the redirect error handler, I have written a few additional test cases that tests it against all 3 types of redirect - HTTP redirect, HTTPS redirect, Relative URL redirect.

The diff is a little messy because I moved the original test case written by the contributor who added the feature and ordered it according to the type of redirect that was being tested.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aeneasr aeneasr merged commit 24bdd9b into ory:master Sep 28, 2020
@aeneasr
Copy link
Member

aeneasr commented Sep 28, 2020

Awesome 🎉

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants