Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsingular_julia.so: undefined symbol in CI #4341

Closed
lgoettgens opened this issue Nov 22, 2024 · 10 comments · Fixed by JuliaPackaging/Yggdrasil#9864
Closed

libsingular_julia.so: undefined symbol in CI #4341

lgoettgens opened this issue Nov 22, 2024 · 10 comments · Fixed by JuliaPackaging/Yggdrasil#9864
Labels

Comments

@lgoettgens
Copy link
Member

Since about an hour ago, all CI jobs of Oscar fail with

/opt/hostedtoolcache/julia/1.10.6/x64/bin/julia: symbol lookup error: /home/runner/.julia/artifacts/cf0ff4f151918145bd7c13270aae66e73a2cc2d9/lib/libsingular_julia.so: undefined symbol: _Z4kStdP10sip_sidealS0_6tHomogPP6intvecS3_iiS3_PFiP10skStrategyE
Package Oscar errored during testing (exit code: 127)

As this error mentions singular, and there has been a release of Singular_jll at about that time, I suspect this to correlate somehow.

ping @hannes14

@benlorenz
Copy link
Member

That symbol seems to point to the old intvec version of kstd:
Singular/Singular@fdca752#diff-e0d539743ed77af80cf62b0c1cb0242fe497fcb6b72bb74e179c68485ee6d91fL41-R42

@fingolfin
Copy link
Member

c++filt says:

kStd(sip_sideal*, sip_sideal*, tHomog, intvec**, intvec*, int, int, intvec*, int (*)(skStrategy*))

@benlorenz
Copy link
Member

Similar error again with the new version (Singular_jll v404.0.708) but with a different symbol,
_Z8kMin_stdP10sip_sidealS0_6tHomogPP6intvecRS0_S3_ii:

kMin_std(sip_sideal*, sip_sideal*, tHomog, intvec**, sip_sideal*&, intvec*, int, int)

https://github.com/oscar-system/Oscar.jl/actions/runs/11973443988/job/33401803885?pr=4286#step:8:527

@fingolfin
Copy link
Member

@hannes14 made a new release fixing that but now it fails in

idElimination(sip_sideal*, spolyrec*, intvec*, GbVariant)

@fingolfin
Copy link
Member

In addition libsingular-julia cannot be built against the current Singular_jll, the errors (see JuliaPackaging/Yggdrasil#9839) suggest that also kStd has a breaking change.

I would suggest that for further changes we stop the whack-a-mole and the new Singular commit is first tested locally. One way how to do this is described in README.maintainer.md inside the Singular.jl repository, in the final section Building a custom Singular_jjl locally

@thofma
Copy link
Collaborator

thofma commented Nov 23, 2024

Can we revert whatever started this to get a working Oscar again?

@fingolfin
Copy link
Member

Yeah we should yank the last couple bad Singular_jll releases. Unfortunately I can't access a computer right now to do it (maybe later today if nobody beats me to it)

@hannes14
Copy link
Member

JuliaPackaging/Yggdrasil#9851 works locally with the tests of Singular.jl and Oscar.jl

@thofma
Copy link
Collaborator

thofma commented Nov 23, 2024

I think it broke the doctests, so this release of Singular_jll is still breaking Oscar development.

See: https://github.com/oscar-system/Oscar.jl/actions/runs/11983625740/job/33427069919

@lgoettgens
Copy link
Member Author

Would it be possible to revert all of these Singular_jll versions from the last days asap? Until this is fixed, we have failures in CI, see https://github.com/oscar-system/Oscar.jl/actions/runs/12002618979/job/33454875472#step:8:944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants