-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put LICENSE to the JAR #188
Comments
Hi, thanks for reporting the issue! |
https://github.com/merkle-open/gradle-license-enforce-plugin fetches information from Maven POM file |
I'm not good at software licensing, but in apache license page Distributing source code and binary files are two different things and in both cases you need a license file(in source code is present). Most likely, the licenses in maven pom refer only to the maven repository and the correct check is checking the license file. But I`m not suer whether it is necessary to put the linece file into the jar.
Thanks for link, I chose my plugin because it is more popular and I hope that its support will not be discontinued. |
So it sounds like having it in the pom.xml is enough (and more standard). |
I use the same https://github.com/jk1/Gradle-License-Report plugin to check dependencies license and ran into the same problem. Interestingly this wasn't a problem back in v1.x.x, problem starts from v2 onwards Either way would be good to have this fixed |
I can fix this problem if the owners of the project don't mind. |
sure, go ahead and send a PR. |
The problem turned out to be more complicated than I expected. The solution to this problem is to change the type of dependency to P.S. the plugin is able to process the license from the POM. |
solved in #191 version |
I use gradle plugin for automatic check dependencies licenses. But your library not verified, because in your jar file license not present.
Can you put license to JAR file?
The text was updated successfully, but these errors were encountered: