Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging.exit signature doesn't support ? #84

Closed
corneil opened this issue Aug 6, 2019 · 3 comments
Closed

logging.exit signature doesn't support ? #84

corneil opened this issue Aug 6, 2019 · 3 comments

Comments

@corneil
Copy link
Contributor

corneil commented Aug 6, 2019

The signature for logger.exit should be override inline fun <T : Any> exit(retval: T?): T?
@oshai
Copy link
Owner

oshai commented Aug 6, 2019

I think it's true. do you want to contribute that, or should I fix it?

@corneil
Copy link
Contributor Author

corneil commented Aug 6, 2019

I'm busy preparing PR

@oshai
Copy link
Owner

oshai commented Aug 7, 2019

fixed in 1.7.3 and PR #85 Thanks!

@oshai oshai closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corneil @oshai