-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spain’s “A-roads” do not necessarily have blue shields #654
Comments
Since it's tagged at the network level, this is feasible. However, remember that network and ref are packed into a single tile attribute per route, so you have something like:
The However, this will mean that any other network that happens to use This is exactly the kind of craft-mapped boutique output that I'd encourage in this project... |
Once #1032 lands, we’ll be able to make the route’s |
As of #1032, each feature has a We’ll need to modify the shield library’s public interface to pass in an optional color: At this point, |
Currently, this project assumes that every route relation tagged
network=ES:A-road
is an autopista or autovía that has a blue shield. Neither assumption is correct with respect to OSM. In reality, Spain’s route designation situation is almost as complex and inconsistent as in the U.S. Although the national government often applies a blue shield and “A-” or “AP-” prefix to autopistas and autovías, many have the prefix “R-” (for radial) or “AP-” (for autopista de peaje), making it less clear whether these routes should be considered “A-roads”.Meanwhile, each of the autonomous communities has its own conflicting scheme for local autovías. For example, in Andalusía (which happens to start with an A), Autovía A-92 has an orange shield, while Autovía A-382 has a green shield. In Castile and León, Autovía A-231 has a blue shield. In the Basque Country, Autovía AP-1 is neither nationally operated nor tolled but still has the “AP” prefix and blue shield.
Due to the large number of idiosyncrasies, the Spanish community has adopted the
ref:colour
key to indicate the shield color independently of the route network. It would be better to base the shield selection on this data than to maintain an override list ourselves, since the assigned colors apparently change regularly. The vector tiles would need to exposeref:colour
, ideally coalescing similarly hexadecimal color references into more predictable color keywords. In the meantime, maybe we should remove the existing blue-only implementation to avoid confusion:https://github.com/ZeLonewolf/openstreetmap-americana/blob/e5fe35be2653a0cf96acec634e49fe3df829dce1/src/js/shield_defs.js#L3324-L3328
The text was updated successfully, but these errors were encountered: