Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch postcodes containing a space are not found #1027

Closed
PanderMusubi opened this issue Apr 30, 2018 · 8 comments
Closed

Dutch postcodes containing a space are not found #1027

PanderMusubi opened this issue Apr 30, 2018 · 8 comments

Comments

@PanderMusubi
Copy link

PanderMusubi commented Apr 30, 2018

Dutch postcodes containing a space are not found. This bug came to light by using Thunderbird Address Book which can open Nominatim for an address.

Examples that do work are:

Examples that do not work with space are:

Example that doesn't work with or without space is:

It doesn't matter is the space in the url is a space , a plus + or %20.

@PanderMusubi
Copy link
Author

PanderMusubi commented Apr 30, 2018

Note that Thunderbird Address Book creates search links in this way. Perhaps it should use more advanced search with named fields? See also https://wiki.openstreetmap.org/wiki/Nominatim#Parameters and https://bugzilla.mozilla.org/show_bug.cgi?id=531285

@mtmail
Copy link
Collaborator

mtmail commented May 1, 2018

Base issue is that Nominatim currently can't handle 4 digit Dutch postcodes, it simply doesn't know where they are. It's been reported in #1009 and we want to fix it with #1011

@PanderMusubi
Copy link
Author

I'm referring to postcodes that do have the two letters, such as 1234 AB. Only the space that is in there is not being processed properly. Removing the space is one way of solving it, however many people use the space. Think that is also still the official format.

@PanderMusubi
Copy link
Author

@mtmail So if it is know which value is which type, do you advise using named parameters? The Thuderbird Address Book known which part is the street name, postal code, city, etc.

@mtmail
Copy link
Collaborator

mtmail commented May 1, 2018

The 1234AB vs 1234 AB is similar and we'll address that (no pun intended) in the change. Nominatim needs to and currently doesn't understand no space, space, and dash formats in the postcodes. Several countries have similar formats, e.g. United States 5 digit vs 8 digit postcodes (usually dash-separated), Brazil, Great Britain...

Placing the address components into a structured query (&street=...&city=...) as work-around has no effect here because Nominatim search logic is about the same.

@PanderMusubi
Copy link
Author

Haha.

If not for a workaround and independent of the issue, would you recommend Thunderbird (and others) using a structured query?

@mtmail
Copy link
Collaborator

mtmail commented May 2, 2018

Structured queries are still marked experimental in our documentation https://wiki.openstreetmap.org/wiki/Nominatim#Search I'd use unstructured, basically list address components comma separated sorted by small->large (house number -> country).

There's quite a few places in the world with are both cities and states (Berlin, Hamburg) or city and county (most metropolitan areas like London). Manhatten (a borough) or Paris Arrondissements (a quarter) don't seem to fit into either a suburb or city definition.

@lonvia
Copy link
Member

lonvia commented May 5, 2018

Duplicate of #927.

@lonvia lonvia closed this as completed May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants