-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ul." may be safely discarded from searches for Polish roads - (short for street in polish) #87
Comments
In general Nominatim should be more forgiving for such "partial matches". |
It seems to me that this problem was addressed and this issue can be closed. |
@matkoniecz example does not work anymore, as well as other queries with "ul". There seems to be a regression. |
Looks like the Polish community has decided to completely get rid of street designations. Nominatim can go from 'ulica' to 'ul' but not from nothing to 'ul'. Might get better with #2944. But in the grand scheme of things the tagging is rather unfriendly to data users, so this will never work well. |
I think we never had them. Polish community has some weird ideas about street names (expanding actual street name to full name of a person, irregardless of actual street name and "fixing" some "incorrect" street names, for example) but skipping "Ulica" matches general norms in Polish language and Polish cartography. I checked for example https://www.openstreetmap.org/way/24216183/history that has versions dating back to 2008 and it never had "ulica" in name. |
that one seems specifically about ordinals
Does not work anymore, so I would want to reopen. But given
it seems that it would be closed anyway. |
And that's exactly the tagging error here. "name" should not contain the label of the street you want to see rendered in cartagrophy. It should contain it's name. Polish Wikipedia at least seems to think the name is 'Ulica Pędzichów', so I take it that the designation is part of the name, it is just normally omitted. Nominatim could add a rule that expands every street name with a 'Ulica' in Poland. But first of all, I expect it would go wrong for all the streets which have a different designation ('Aleja Pokou' for example) and second, it only patches up the problem for one software. That's were I usually draw the line and say: this needs a better representation in the data. |
The problem is that "Pędzichów" is the common name, not "Ulica Pędzichów". In similar way, Manchester may be considered as having full name "City of Manchester" if Wikipedia is to be believed, but it will have BTW, Nominatim also fails to find "City of Manchester". It is not really a tagging for renderer.
Yes, but it is omitted so typically that it is not part of the common name. Polish Wikipedia has its own share of weird naming ideas and sometimes using super-official naming forms. For example https://pl.wikipedia.org/wiki/Park_Krakowski_im._Marka_Grechuty is using |
It's simple really. Either "Pędzichów" is the only common name, then the complaint that "ul . Pędzichów" isn't found is mute. Or "Ulica Pędzichów" is the official name and should be found, then it should be added to OSM. |
The problem is that
Though "Berlin city" or "city Berlin" and "street Pędzichów" is not being interpreted by Nominatim either, so maybe anyone geocoding Polish addresses with Nominatim should add this transform on its own and do not expect Nominatim to handle it? Or maybe it is at least test case where it happens: |
Note that there is #2944 in the works. Once implemented, that should solve the problem. |
"Kraków, ul. Pędzichów 27" fails to find location, but "Kraków, Pędzichów 27" is successful.
The text was updated successfully, but these errors were encountered: