Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license check fail to find FSF/OSI license #1384

Closed
szuecs opened this issue May 21, 2024 · 2 comments · Fixed by #1411
Closed

license check fail to find FSF/OSI license #1384

szuecs opened this issue May 21, 2024 · 2 comments · Fixed by #1411

Comments

@szuecs
Copy link

szuecs commented May 21, 2024

PR triggered a change in the scorecard for the license check.
https://github.com/zalando/skipper/blob/master/LICENSE is in general Apache but for one directory pathmux it's MIT.
The license list shows that both are FSF and OSI license compliant.

image

  1. Why does it fail?
  2. Can we apply a workaround? As far as I understand Alternately, create a LICENSE directory and add a license file(s) with a name that matches your [SPDX license identifier](https://spdx.org/licenses/). such as LICENSES/Apache-2.0.txt. could be a viable workaround. As far as I understand the text it would be possible to add empty files LICENSES/Apache-2.0.txt and LICENSES/MIT.txt to workaround the problem, right?
@spencerschrock
Copy link
Member

  1. We rely on the GitHub / GitLab license type detection, which doesn't always work when you modify the license text.
  2. The workaround doesn't seem like it would work here based on how the code exits currently.

We shouldn't be warning on this part in my opinion, and it should be easy to tweak the threshold so it doesn't create a code scanning alert over this.

@szuecs
Copy link
Author

szuecs commented May 27, 2024

@spencerschrock thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants