Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD rate limit improvements #2603

Closed
spencerschrock opened this issue Jan 18, 2023 · 2 comments · Fixed by #2609
Closed

CI/CD rate limit improvements #2603

spencerschrock opened this issue Jan 18, 2023 · 2 comments · Fixed by #2609
Labels
github_actions Pull requests that update Github_actions code

Comments

@spencerschrock
Copy link
Member

spencerschrock commented Jan 18, 2023

Currently we run every check on PRs when submitted, commits pushed to the PR source branch, etc.

If we break the actions into light/heavy we could save some API limits.

Light (think unit tests) get run on every commit, heavy (e2e) get run once the pull request is approved and ready to merge.

Maybe this trigger since we need an approval for lastest commits anyway?
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-a-workflow-when-a-pull-request-is-approved

Or something with labels(https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) if we want certain failures to be surfaced sooner.

@spencerschrock spencerschrock changed the title CI/CD Improvements CI/CD rate limit improvements Jan 18, 2023
@spencerschrock
Copy link
Member Author

We will likely need to revert this.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflows-in-forked-repositories-1

This is causing the integration tests to fail since they can't access secrets. Secrets are accessible through pull_request_target, so any filtering would need to be done with that trigger.

@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2023
@afmarcum afmarcum added github_actions Pull requests that update Github_actions code and removed GitHub Actions labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants