Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add PR information in the details of CI-Tests, Code-Review and SAST checks #2798

Closed
pnacht opened this issue Mar 28, 2023 · 2 comments · Fixed by #2835
Closed

Feature: Add PR information in the details of CI-Tests, Code-Review and SAST checks #2798

pnacht opened this issue Mar 28, 2023 · 2 comments · Fixed by #2835
Assignees
Labels
kind/enhancement New feature or request

Comments

@pnacht
Copy link
Contributor

pnacht commented Mar 28, 2023

Is your feature request related to a problem? Please describe.
It isn't possible to determine which PRs passed or failed according to CI-Tests, Code-Review or SAST checks. This is unfortunate because projects with "unusual" setups frequently get less than a 10/10 for reasons that aren't entirely clear. For example, google/guava (API results) gets a 9/10 because only 28/30 PRs counted as reviewed. Given the project's unusual setup (using a bot to force-push commits to main instead of merging PRs), it's hard to diagnose what happened to the 2 missing PRs.

Describe the solution you'd like
Information on passing and failing PRs should be displayed whenever these checks are run with --show-details. It is my understanding that none of these checks currently use the details field, so there should be minimal risk of disrupting dependencies.

@ashishkurmi
Copy link
Contributor

I am interested in implementing this feature.
@ossf/scorecard-maintainers: Could you please assign this issue to me If no one else has volunteered? I would love the opportunity to take on this task and work towards its successful implementation.

@laurentsimon
Copy link
Contributor

Done! Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
3 participants