Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Security-Policy throws a warning if target repo's org has an empty .github repo #3076

Closed
pnacht opened this issue May 26, 2023 · 0 comments · Fixed by #3433
Closed

BUG: Security-Policy throws a warning if target repo's org has an empty .github repo #3076

pnacht opened this issue May 26, 2023 · 0 comments · Fixed by #3433
Labels
kind/bug Something isn't working

Comments

@pnacht
Copy link
Contributor

pnacht commented May 26, 2023

Describe the bug
If the Security-Policy check is run for a repo owned by an org with an empty .github repo, it runs a warning. All the examples I've checked don't have a security policy, so I'm not sure if the check runs normally (the warning says "Skipping...", so I assume it keeps working correctly).

Reproduction steps
Steps to reproduce the behavior:

  1. scorecard --repo bazelbuild/rules_sass --checks Security-Policy --format json
unable to get tarball tarball not found: https://api.github.com/repos/bazelbuild/.github/tarball/. Skipping...
[ ...valid JSON output... ]

Note that https://github.com/bazelbuild/.github is empty.

Expected behavior
An empty .github repository should behave identically to one with content but without a SECURITY.md file. So the warning shouldn't be thrown.

Additional context
Empty .github repositories seem to be common with Google-associated orgs, since I've found this for many other projects. The warning is thrown for projects in these orgs as well (at least for the specific repos I've tried):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant